ci: sign image builds (fixing security issue) #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arthurus-rex thank again. The CI still fails due to missing DCO. Please find instructions here or by clicked in the failure details |
Added image signing to workflow using cosign. Signs images with GitHub OIDC token, and permissions updated and restricted to reflect this. Signed-off-by: Arthur Savage <[email protected]>
|
Okay, I think I fixed it. Apologies, this is my first significant PR. |
dave-tucker
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added image signing to workflow using cosign. Signs images with GitHub OIDC token, and permissions updated and restricted to reflect this.
This is a re-created PR due to previous difficulty with rebasing changes on main. I hope this fixes the issue!