-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: sign all image builds #1691
Conversation
🤖 SeineSailor Here is a concise summary of the pull request changes: Error Handling and Code Consistency: Replaced hardcoded error strings with a variable, improved error handling, and updated the creation of error variables. Modified the Code Organization and Maintainability: Renamed variables to follow a consistent naming convention, introduced helper functions, and updated Go dependencies to improve project security and maintainability. Image Security and Compression: Introduced cryptographic signing to two additional workflows, reduced privileges in the Build and Deployment: Introduced a new Observations and Suggestions:
|
I can see that one of the integration tests here failed, but at a glance, it doesn't seem to me like this failure is related to the changes I've applied to this PR. If it is, then I will gladly make any necessary changes. |
CI failure potentially addressed in #1686 |
Got it. I will incorporate changes once fix is finalized. |
@arthurus-rex can you rebase to pick up the CI fix? |
Successfully rebased! |
6c9b7eb
to
b2ed71d
Compare
Add cosign to two additional image building workflows to resolve intermittent signing issue. Uses GitHub OIDC token for signing, and narrows scope of privileges to only what is necessary to write token. Signed-off-by: Arthur Savage <[email protected]>
This builds on previous commit
9d567e5
to add cryptographic signing to two additional workflows:image_pr.yml
andimage_base.yml
. This resolves the issue with images only being intermittently signed. It also reduces the scope of privileges onimage.yml
to only what is necessary for the OIDC token to be used.