Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compute idle power with core ratio #1732

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

sunya-ch
Copy link
Collaborator

@sunya-ch sunya-ch commented Aug 26, 2024

This patch is for adding an idle power based on ratio of the machine cores over the cores of the machine that is used for training the power model.

This PR can be merged independently but there is no core ratio set yet.

For local regressor core ratio, need the following Kepler PR to solve the TODO.

For sidecar estimator, need the following PR in kepler-model-server to have estimator provides machine spec and server API to put machine spec to weight response.

Signed-off-by: Sunyanan Choochotkaew [email protected]

Signed-off-by: Sunyanan Choochotkaew <[email protected]>
Copy link
Contributor

github-actions bot commented Aug 26, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This pull request introduces a new feature to improve idle power estimation by considering the core ratio of the machine used for training the power model. Key modifications include:

  • Adding coreRatio fields to Regressor and EstimatorSidecar structs
  • Updating getWeightFromServer, GetPlatformPower, and GetComponentsPower methods to incorporate coreRatio parameter
  • Modifying GetComponentPower and GetPlatformPower functions in utils package to accept coreRatio parameter
  • Adding a new GetCoreRatio function to return the core ratio for idle power estimation

Impact: These changes may affect calling or dependent code, particularly in areas where Regressor and EstimatorSidecar structs are used. The external interface and behavior of the code are also affected, as the power estimation functionality has been modified.

Observations: The changes are well-organized and grouped by functionality, making it easier to understand the impact of each modification. However, it would be beneficial to include additional comments or documentation to explain the reasoning behind the changes and how they improve idle power estimation.

@sunya-ch sunya-ch requested a review from rootfs August 26, 2024 07:34
@rootfs
Copy link
Contributor

rootfs commented Aug 26, 2024

per Pang's instruction, this PR can be merged independently. Let's have this one first and wait for #1684

@rootfs rootfs merged commit 28d42a4 into sustainable-computing-io:main Aug 26, 2024
21 checks passed
maryamtahhan pushed a commit to maryamtahhan/kepler that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants