Fix accelerator device map #1913
Conversation
|
🤖 SeineSailor Here is a concise summary of the pull request changes: Summary: The "Fix accelerator device map" pull request refactors the accelerator device map logic, improving internal diagnostics and adding log statements for better visibility. Key modifications include corrections to device map addition logic and the introduction of the Impact: These changes enhance the code's internal functionality without affecting the external interface or behavior, except for the added Observations: The changes are focused on internal improvements, suggesting a refinement of the existing implementation rather than a significant architectural shift. The addition of log statements and diagnostics will aid in debugging and troubleshooting. Suggestions: Consider adding tests to validate the corrected device map logic and the new |
vimalk78
force-pushed
the
fix-accel-map
branch
from
33fdffa to
40b36a1
Compare
|
can you sign DCO? |
…sustainable-computing-io#1809)" This reverts commit 91c8e62. Signed-off-by: Vimal Kumar <[email protected]>
Signed-off-by: Vimal Kumar <[email protected]>
vimalk78
force-pushed
the
fix-accel-map
branch
from
40b36a1 to
9ca44bf
Compare
@rootfs signed DCO |
There was a problem hiding this comment.
Adding .dockerignore will lead to incorrect version computation #1809
| @@ -138,6 +139,7 @@ func (d *gpuDcgm) InitLib() (err error) { | |||
| if err != nil { | |||
| klog.Infof("There is no DCGM daemon running in the host: %s", err) | |||
| // embedded mode is not recommended for production per https://github.com/NVIDIA/dcgm-exporter/issues/22#issuecomment-1321521995 | |||
| klog.Info("Attempting to inilialize dcgm in Embedded mode.") | |||
.dockerignorefile