Skip to content

Commit

Permalink
fix: various crashes
Browse files Browse the repository at this point in the history
fix: remove negative margin when displayName is absent
  • Loading branch information
suvam0451 committed Jan 16, 2025
1 parent 122248a commit 6c9570e
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 6 deletions.
4 changes: 2 additions & 2 deletions apps/mobile/app.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ const expo = ({ config }: ConfigContext): ExpoConfig => ({
silentLaunch: true,
},
ios: {
bundleIdentifier: IS_DEV ? 'io.suvam.dhaaga.dev' : 'io.suvam.dhaaga.lite',
bundleIdentifier: IS_DEV ? 'io.suvam.dhaaga.dev' : 'io.suvam.dhaaga',
supportsTablet: false,
},
android: {
package: IS_DEV ? 'io.suvam.dhaaga.dev' : 'io.suvam.dhaaga.lite',
package: IS_DEV ? 'io.suvam.dhaaga.dev' : 'io.suvam.dhaaga',
versionCode: 21,
},
androidStatusBar: {
Expand Down
7 changes: 6 additions & 1 deletion apps/mobile/components/common/status/Fragments.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,12 @@ function PostedByTextOneLine({
marginBottom: appDimensions.timelines.sectionBottomMargin,
}}
>
<AppText.Medium>{parsedText}</AppText.Medium>
<TextContentView
tree={parsedText}
variant={'displayName'}
mentions={[]}
emojiMap={new Map()}
/>
<AppText.Normal
style={{
fontSize: 13,
Expand Down
2 changes: 1 addition & 1 deletion apps/mobile/components/common/status/StatusItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ function StatusItem({ isPreview, isPin, showFullDetails }: StatusItemProps) {
hasBoost={true}
hasParent={true}
isPreview={isPreview}
isPin
isPin={isPin}
showFullDetails={showFullDetails}
/>
</PostContainer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export function OriginalPosterPostedByFragment({
mentions={[]}
emojiMap={emojiMap}
oneLine
style={{ marginBottom: -4 }}
style={{ marginBottom: displayNameParsed.length > 0 ? -4 : 0 }}
/>
<Text
style={{
Expand Down
2 changes: 1 addition & 1 deletion apps/mobile/services/session/account-session.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class AccountSessionManager {
// avoid storage reads
let store = null;

if (emojiMap.has(id)) {
if (emojiMap?.has(id)) {
return {
url: emojiMap.get(id),
shortCode: id,
Expand Down

0 comments on commit 6c9570e

Please sign in to comment.