Merge v3.2.4 release candidate for final release

[gonuke]

This release candidate has been available for 7 weeks and there are no additional changes requested.

Requires merge to support finalization of the draft release.

[ahnaf-tahmid-chowdhury]

Should we still consider this?

[gonuke]

I think this change makes sense - it fixes one problem, but there is now a new linking problem on Windows because we don't find the HDF5 library at link time. I haven't had time to figure out why.

[ahnaf-tahmid-chowdhury]

I think the new HDF5 comes with a new pkgconf, which is causing the linking issue.

We could consider running:

brew link --overwrite pkgconf
or
brew reinstall pkg-config

[gonuke]

I don't know enough about brew to know in which order this would come relative to the lines we already have?

[ahnaf-tahmid-chowdhury]

It appears that only HDF5 version 1.10.6 works for windows builds at the moment. The latest version, 1.14.4, doesn't include essential files like libhdf5.lib, among others, which might explain the issue. When I attempted to use version 1.12.2, I encountered the following error:

LINK : warning LNK4286: symbol '?find@Range@moab@@QEBA?AVconst_iterator@12@_K@Z (public: class moab::Range::const_iterator __cdecl moab::Range::find(unsigned __int64)const )' defined in 'Range.obj' is imported by 'Intx2Mesh.obj' [D:\a\dagmc-ci\moab_build\src\MOAB.vcxproj]
... (truncated warnings) ...
D:\a\dagmc-ci\moab_build\lib\Release\MOAB.dll : fatal error LNK1169: one or more multiply defined symbols found [D:\a\dagmc-ci\moab_build\src\MOAB.vcxproj]

For now, I’ve set the HDF5 version to 1.10.6. I assume, the MOAB library needs updates to properly support newer versions of HDF5 for Windows builds.

[ahnaf-tahmid-chowdhury]

@gonuke, it seems yaml-cpp is a core dependency now. Please let me know how to address the gtest error.

[gonuke]

I think this is failing for Windows on a very specific issue: CMake found the HDF5 libraries successfully during the configuration step, but they are not being found at the linking step. I am not sure how best to address this in Windows. I know there has been some substantial overhaul for Windows build in MOAB on the master branch, but switching to master didn't help.

[bam241]

LGTM!

One minor change/comment to explain why all trigger on the Windows build have been commented.