Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npx sv add tailwindcss seems to do nothing #389

Open
crummy opened this issue Jan 8, 2025 · 5 comments · May be fixed by #394
Open

npx sv add tailwindcss seems to do nothing #389

crummy opened this issue Jan 8, 2025 · 5 comments · May be fixed by #394
Labels
bug Something isn't working pkg:add sv add

Comments

@crummy
Copy link

crummy commented Jan 8, 2025

Describe the bug

I have been following the instructions here https://next.shadcn-svelte.com/docs/installation/sveltekit to set up shadcdn with svelte, which involves installing Tailwind. However, the command npx sv add tailwindcss doesn't seem to apply any changes to my codebase.

Reproduction

https://stackblitz.com/edit/sveltejs-kit-template-default-sr1rca5l?file=package.json

-> in the terminal, type npx sv add tailwindcss

Logs

~/projects/sveltejs-kit-template-default-sr1rca5l
❯ npx sv add tailwindcss
Need to install the following packages:
[email protected]
Ok to proceed? (y) 
┌  Welcome to the Svelte CLI! (v0.6.10)

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @sveltejs/adapter-auto: ^3.0.0 => 3.3.1 
    @sveltejs/kit: ^2.0.0 => 2.15.2 
    @sveltejs/vite-plugin-svelte: ^4.0.0 => 4.0.4 
    svelte: ^5.0.0 => 5.16.6 
    vite: ^5.4.11 => 5.4.11 

Severity

serious, but I can work around it

Additional Information

I'm not actually sure what I'm expected to see, but probably some changes to the package.json and app.css ?

@Conduitry Conduitry transferred this issue from sveltejs/kit Jan 8, 2025
@manuel3108 manuel3108 added bug Something isn't working pkg:add sv add labels Jan 9, 2025
@manuel3108
Copy link
Member

Normally, it lets you select which plugins you want to choose (this is btw how it works for me locally):

┌  Welcome to the Svelte CLI! (v0.6.10)
│
◆  Which plugins would you like to add?
│  ◻ typography (@tailwindcss/typography)
│  ◻ forms
│  ◻ container-queries
└

Im able to reproduce the error inside stackblitz though. Is this where you initially experience the error, or was this locally?

@crummy
Copy link
Author

crummy commented Jan 9, 2025

I discovered the error locally first.

@manuel3108
Copy link
Member

Interesting! At least in stackblitz this seems to affect all other adapters. But for whatever reason the create command works just fine. Does it behaves the same way for you locally?

@manuel3108
Copy link
Member

manuel3108 commented Jan 12, 2025

Seems like one of our preconditions is causing this problem.

Workaround:

npx sv add tailwindcss --no-preconditions

By any chance, do you have a local git binary installed on your local computer? Stackblitz does not seem to have one. But I'm not sure if this is actually the root cause.

@manuel3108 manuel3108 linked a pull request Jan 12, 2025 that will close this issue
@crummy
Copy link
Author

crummy commented Jan 12, 2025

Hmm, I can't actually reproduce it anymore locally. I use git daily though. Weird!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:add sv add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants