fix: git detection inside preconditions failed #394
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d410a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
manuel3108
force-pushed
the
fix/addons-in-stackblitz
branch
from
077ab74 to
679ff83
Compare
manuel3108
changed the title
Conduitry
reviewed
Jan 12, 2025
Co-authored-by: Conduitry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #389
Don't use
tinyexecfor the git detection anymore, as it's doing strange stuff and completely bailing out of the program. This can be reproduced here: https://stackblitz.com/edit/node-jdza4knz?file=index.js. Below the code that is not working, you will also find an alternative that is directly invoking the defaultexecwhich works just fine.This PR switches from
tinyexecto defaultexecfor the git detection