-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for create
api
#36
Conversation
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've pushed some tweaks to fix the rollup output, but i also pissed off eslint in the process. im not exactly sure how to fix that error, but i've got to run off for now. once that's fixed, feel free to merge!
Thanks, totally missed that i was only outputting the bin file - good catch. As for the error, I have no clue what's happening. I went back to 902b2c5 (first commit in this PR) commit by commit, and I'm still able to reproduce that error on this commit. That doesn't make any sense thoo, as the pipelines report all greens until your push earlier. The lockfile is not updated, so we shouldn't have any problems with it pulling some new version from somewhere. |
yea, the painful bit is that running edit: it was broken locally for me because of the |
Nice, great! |
Edit: necessary for #32