Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for create api #36

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Conversation

manuel3108
Copy link
Member

@manuel3108 manuel3108 commented Sep 27, 2024

Edit: necessary for #32

import { create } from 'sv';
import path from 'node:path';

const output = path.join(process.cwd(), 'temp');
create(output, {
	name: 'test',
	template: 'skeleton',
	types: 'none'
});

Copy link

pkg-pr-new bot commented Sep 27, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/ast-tooling@36
pnpm add https://pkg.pr.new/sveltejs/cli/sv@36
pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/core@36

commit: 4ea2b87

Copy link
Member

@AdrianGonz97 AdrianGonz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've pushed some tweaks to fix the rollup output, but i also pissed off eslint in the process. im not exactly sure how to fix that error, but i've got to run off for now. once that's fixed, feel free to merge!

@manuel3108
Copy link
Member Author

Thanks, totally missed that i was only outputting the bin file - good catch.

As for the error, I have no clue what's happening. I went back to 902b2c5 (first commit in this PR) commit by commit, and I'm still able to reproduce that error on this commit. That doesn't make any sense thoo, as the pipelines report all greens until your push earlier. The lockfile is not updated, so we shouldn't have any problems with it pulling some new version from somewhere.

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Sep 29, 2024

yea, the painful bit is that running pnpm eslint is completely broken for me locally, even on main. not exactly sure why, but it sure does make debugging this issue more annoying

edit: it was broken locally for me because of the temp folder that can be created inside of adder-template. should be fixed now

@manuel3108
Copy link
Member Author

Nice, great!

@manuel3108 manuel3108 merged commit e9b6e96 into main Sep 30, 2024
5 checks passed
@manuel3108 manuel3108 deleted the feat/programmatic-api-usage branch September 30, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants