Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: utilize prepack lifecycle script #396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hyunbinseo
Copy link
Contributor

@hyunbinseo hyunbinseo commented Jan 14, 2025

The prepack lifecycle script runs before the npm pack and npm publish commands.

By utilizing this:

  1. the prepublishOnly lifecycle script can be removed, which contained an npm command.1
  2. it works with npm pack.

Note

The [email protected] CLI does run the pack command, but it does not run the lifecycle scripts.

So && publint should be included at the end of the prepack script.

This is correctly implemented from [email protected], thus the SemVer is updated to ^0.3.2.

Footnotes

  1. I hope they are changed to node --run in the future when SvelteKit requires Node.js 22+.

Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 5b18de6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 14, 2025

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@396
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@396

commit: 5b18de6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant