Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sv kit as alias for svelte-kit command #397

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rChaoz
Copy link

@rChaoz rChaoz commented Jan 15, 2025

(Partially?) closes #101

Adds a new alias command sv kit that calls svelte-kit, and documents it.

If all is good I'm happy to open a parallel PR to update SvelteKit's CLI page to either redirect to this or at least link it as the new CLI to use

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 826050c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

I'm not sure this really makes sense. We're executing sv via npx, but SvelteKit is installed. We had at one point talked about having sv installed as well in which case additional aliases would make more sense. But we didn't end up going that direction. We should probably close the issue instead

@Conduitry
Copy link
Member

Yeah, I'd be in favor of closing this and the corresponding issue. I don't think we want to have sv be a dependency of SvelteKit apps - there's no reason for them to have all the code needed to scaffold new projects or to migrate code. And if sv isn't a dependency, we don't want to encourage people to pull it down with npx just to have it call a dependency that they already have.

@rChaoz
Copy link
Author

rChaoz commented Jan 15, 2025

We're executing sv via npx, but SvelteKit is installed.

I had no idea, I always install sv instead, my check script even does sv check instead of svelte-check, I thought this was the intended direction; is this not why sv check exists?

If the intended direction is for sv to be just a tool for bootstrapping projects, I think this should be more clear, as currently it's defined as:

The command line interface (CLI), sv, is a toolkit for creating and maintaining Svelte applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider aliasing other Svelte CLIs
3 participants