-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace prettier workspace property #76
Conversation
commit: |
Err, one potential issue I just thought of is if the project may live within a monorepo, but it's not actively part of the monorepo. For instance, it's excluded from the Also how will this affect our tests? Maybe we should wrap it with a |
I suppose that's possible, but it doesn't seem super common. I don't think we're going to be able to implement that level of detail pre-launch. It seems like something we could come back and do it later if someone runs into it being an issue. |
Good point, added a not in #32 |
Make this a bit more generic. I don't know if it's scalable for every adder to add properties to the workspace for each module they might want to detect. This might be a better pattern for community adders to follow and doesn't lock us in to providing that property