breaking: deprecate the svelte/no-dynamic-slot-name rule
#1011
+38
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 477b42b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
baseballyama
force-pushed
the
chore/no-dynamic-slot-name
branch
from
99e340e to
42ecafc
Compare
|
Thank you for this PR! The valid-compile rule assumes this rule exists and excludes it from reporting. |
baseballyama
force-pushed
the
chore/no-dynamic-slot-name
branch
from
42ecafc to
aef695b
Compare
Did!: aef695b |
baseballyama
force-pushed
the
chore/no-dynamic-slot-name
branch
from
aef695b to
61da602
Compare
baseballyama
force-pushed
the
chore/no-dynamic-slot-name
branch
from
61da602 to
477b42b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a compile error occurs in all versions of Svelte (3, 4, and 5), isn’t this rule unnecessary?
Svelte5
https://svelte.dev/playground/hello-world?version=5.17.3#H4sIAAAAAAAAE22NzUrEMBRGX-V6N6NDY_axU6goulC70J0R6TRXCWRuSnL9GUqfwoUbn84nkSAOgm4P5zvfhNxvCA2eUwgRXmIKDvbJeSF3gBU--EAZze2Esh2LVwBWP6t2HA_zMwUpbN1n-o8PkYVYMhqs85D8KI1lAL0EysGzwLepOSq35X7jB5VDFFVaBixSSjFZhKUusyFyFri-6G7ur9rLU1jBYt27xZHlWu_qlus9peDz4w3Ouu4ElGos16UKpbqy-Bijswj6t_wOx-1fF6bd2Qy6wQqFXgWNpCea7-YvjJVwy0IBAAA=
Svelte4
https://svelte.dev/playground/hello-world?version=4.2.19#H4sIAAAAAAAAE22NzUrEMBRGX-V6N6NDY_axU6goulC70J0R6TRXCWRuSnL9GUqfwoUbn84nkSAOgm4P5zvfhNxvCA2eUwgRXmIKDvbJeSF3gBU--EAZze2Esh2LVwBWP6t2HA_zMwUpbN1n-o8PkYVYMhqs85D8KI1lAL0EysGzwLepOSq35X7jB5VDFFVaBixSSjFZhKUusyFyFri-6G7ur9rLU1jBYt27xZHlWu_qlus9peDz4w3Ouu4ElGos16UKpbqy-Bijswj6t_wOx-1fd9p9zaAbrFDoVdBIeqL5bv4Cu-KH80EBAAA=
Svelte3
https://svelte.dev/playground/hello-world?version=3.59.2#H4sIAAAAAAAAE22NzUrEMBRGX-V6N6NDY_axU6goulC70J0R6TRXCWRuSnL9GUqfwoUbn84nkSAOgm4P5zvfhNxvCA2eUwgRXmIKDvbJeSF3gBU--EAZze2Esh2LVwBWP6t2HA_zMwUpbN1n-o8PkYVYMhqs85D8KI1lAL0EysGzwLepOSq35X7jB5VDFFVaBixSSjFZhKUusyFyFri-6G7ur9rLU1jBYt27xZHlWu_qlus9peDz4w3Ouu4ElGos16UKpbqy-Bijswj6t_wOx-1fF6bd2Qy6wQqFXgWNpCea7-YvjJVwy0IBAAA=