Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update README for v3 #1041

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: update README for v3 #1041

wants to merge 2 commits into from

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented Jan 26, 2025

⚠️ We need to merge this PR when we release v3.0.0

I’ve created the README from scratch, updating it mainly based on the ESLint settings generated by the sv create command.
Additionally, I’ve adjusted the style of the documentation site. Since it’s planned to be migrated to Svelte’s official site later, it should be fine unless there’s something significantly wrong.

MEMO

I need to handle #1043

Copy link

pkg-pr-new bot commented Jan 26, 2025

Open in Stackblitz

npm i https://pkg.pr.new/eslint-plugin-svelte@1041

commit: 8eeedb5

Copy link

changeset-bot bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: 9a88c50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@baseballyama baseballyama force-pushed the chore/update-readme branch 18 times, most recently from 6a2ffb5 to 8eeedb5 Compare January 26, 2025 06:13
Copy link
Contributor

github-actions bot commented Jan 26, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@1041

Published Instant Preview Packages:

View Commit

@baseballyama baseballyama force-pushed the chore/update-readme branch 5 times, most recently from b433651 to e5a68ba Compare January 26, 2025 10:30
@baseballyama baseballyama force-pushed the chore/update-readme branch 4 times, most recently from 259067e to cd1a41f Compare January 26, 2025 15:38
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have completely rewritten the README. Could you check if there’s any missing information?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve tidied up the site’s style. Please check if there are any design issues.

@baseballyama baseballyama marked this pull request as ready for review January 26, 2025 15:47
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great! Thank you!

@mikededo
Copy link
Contributor

mikededo commented Feb 4, 2025

Should we also take the opportunity to update the CONTRIBUTING.md file? It was last modified nearly a year ago and there are some things which are not clear (i.e. the scripts section does not mention that such scripts should be executed from packages/eslint-plugin-svelte) or outdated (i.e. such as this script which does not exist).

@baseballyama
Copy link
Member Author

Let’s do this in a separate PR. And contributions are welcome!
I will merge this PR this weekend after confirming that everything is ready to release v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants