Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add *.svelte.{js,ts} config to base config #1043

Merged
merged 2 commits into from
Jan 27, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: add *.svelte.{js,ts} config to base config
ota-meshi committed Jan 26, 2025

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mjcarroll Michael Carroll
commit 3d0aa5dca1add9a559efd0996d21d9ff31eea924
10 changes: 10 additions & 0 deletions packages/eslint-plugin-svelte/src/configs/flat/base.ts
Original file line number Diff line number Diff line change
@@ -34,6 +34,16 @@ const config: Linter.Config[] = [
'svelte/system': 'error'
},
processor: 'svelte/svelte'
},
{
name: 'svelte:base:setup-for-svelte-script',
files: ['*.svelte.js', '*.svelte.ts', '**/*.svelte.js', '**/*.svelte.ts'],
languageOptions: {
parser
},
rules: {
// eslint-plugin-svelte rules
}
}
];
export default config;
109 changes: 66 additions & 43 deletions packages/eslint-plugin-svelte/tools/update-rulesets.ts
Original file line number Diff line number Diff line change
@@ -20,38 +20,61 @@ export function setPluginObject(plugin: ESLint.Plugin): void {
pluginObject = plugin;
}
const config: Linter.Config[] = [
{
name: 'svelte:base:setup-plugin',
plugins: {
get svelte(): ESLint.Plugin {
return pluginObject!;
}
},
},
{
name: 'svelte:base:setup-for-svelte',
files: ["*.svelte", "**/*.svelte"],
languageOptions: {
parser: parser,
},
rules: {
// ESLint core rules known to cause problems with \`.svelte\`.
"no-inner-declarations": "off", // The AST generated by svelte-eslint-parser will false positives in it rule because the root node of the script is not the \`Program\`.
// "no-irregular-whitespace": "off",
// Self assign is one of way to update reactive value in Svelte.
"no-self-assign": "off",
{
name: 'svelte:base:setup-plugin',
plugins: {
get svelte(): ESLint.Plugin {
return pluginObject!;
}
},
},
{
name: 'svelte:base:setup-for-svelte',
files: ["*.svelte", "**/*.svelte"],
languageOptions: {
parser: parser,
},
rules: {
// ESLint core rules known to cause problems with \`.svelte\`.
"no-inner-declarations": "off", // The AST generated by svelte-eslint-parser will false positives in it rule because the root node of the script is not the \`Program\`.
// "no-irregular-whitespace": "off",
// Self assign is one of way to update reactive value in Svelte.
"no-self-assign": "off",

// eslint-plugin-svelte rules
${rules
// eslint-plugin-svelte rules
${rules
.filter((rule) => rule.meta.docs.recommended === 'base' && !rule.meta.deprecated)
.map((rule) => {
const conf = rule.meta.docs.default || 'error';
return `"${rule.meta.docs.ruleId}": "${conf}"`;
})
.join(',\n ')},
},
.join(',\n ')}
},
processor: 'svelte/svelte'
},
},
{
name: 'svelte:base:setup-for-svelte-script',
files: ['*.svelte.js', '*.svelte.ts', '**/*.svelte.js', '**/*.svelte.ts'],
languageOptions: {
parser: parser,
},
rules: {
// eslint-plugin-svelte rules
${rules
.filter((rule) => rule.meta.docs.recommended === 'base' && !rule.meta.deprecated)
.filter(
// Exclude rules that are not applicable to JavaScript files
(rule) =>
rule.meta.docs.ruleId !== 'svelte/comment-directive' &&
rule.meta.docs.ruleId !== 'svelte/system'
)
.map((rule) => {
const conf = rule.meta.docs.default || 'error';
return `"${rule.meta.docs.ruleId}": "${conf}"`;
})
.join(',\n ')}
},
}
]
export default config
`;
@@ -69,20 +92,20 @@ const recommendedContent = `/*
import type { Linter } from 'eslint';
import base from "./base.js"
const config: Linter.Config[] = [
...base,
{
name: 'svelte:recommended:rules',
rules: {
// eslint-plugin-svelte rules
${rules
...base,
{
name: 'svelte:recommended:rules',
rules: {
// eslint-plugin-svelte rules
${rules
.filter((rule) => rule.meta.docs.recommended && !rule.meta.deprecated)
.map((rule) => {
const conf = rule.meta.docs.default || 'error';
return `"${rule.meta.docs.ruleId}": "${conf}"`;
})
.join(',\n ')},
},
}
.join(',\n ')},
},
}
]
export default config
`;
@@ -100,17 +123,17 @@ const prettierContent = `/*
import type { Linter } from 'eslint';
import base from "./base.js"
const config: Linter.Config[] = [
...base,
{
name: 'svelte:prettier:turn-off-rules',
rules: {
// eslint-plugin-svelte rules
${rules
...base,
{
name: 'svelte:prettier:turn-off-rules',
rules: {
// eslint-plugin-svelte rules
${rules
.filter((rule) => rule.meta.docs.conflictWithPrettier)
.map((rule) => `"${rule.meta.docs.ruleId}": "off"`)
.join(',\n ')},
},
}
.join(',\n ')},
},
}
]
export default config
`;