feat: added the consistent-selector-style rule
#925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 70e1add The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marekdedic
force-pushed
the
consistent-selector-style
branch
from
a0301c4 to
df5843e
Compare
marekdedic
force-pushed
the
consistent-selector-style
branch
3 times, most recently
from
49a6b98 to
e963ca7
Compare
marekdedic
force-pushed
the
consistent-selector-style
branch
17 times, most recently
from
55843f5 to
219c6c0
Compare
|
Hi, @ota-meshi! This one is I think ready for review, however, it needs sveltejs/svelte-eslint-parser#619 and #965 first. |
marekdedic
force-pushed
the
consistent-selector-style
branch
2 times, most recently
from
6f4d51b to
e2829bf
Compare
commit: |
marekdedic
force-pushed
the
consistent-selector-style
branch
from
e2829bf to
d40acf7
Compare
marekdedic
commented
Jan 3, 2025
| typeSelections: Map<string, AST.SvelteHTMLElement[]> | ||
| ): boolean { | ||
| const types = new Set(selection.map((node) => node.name.name)); | ||
| if (types.size > 1) { |
There was a problem hiding this comment.
This doesn't report any selection which could be replaced by multiple type selections (e.g. replacing .emphasized {} by i, b {}). That can be added later I think (maybe gated with a configuration option?)
marekdedic
force-pushed
the
consistent-selector-style
branch
from
d40acf7 to
88b68e3
Compare
marekdedic
force-pushed
the
consistent-selector-style
branch
2 times, most recently
from
ffef936 to
3ba8c93
Compare
ota-meshi
requested changes
Jan 14, 2025
packages/eslint-plugin-svelte/src/rules/consistent-selector-style.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-svelte/src/rules/consistent-selector-style.ts
Outdated
Show resolved
Hide resolved
marekdedic
force-pushed
the
consistent-selector-style
branch
from
3ba8c93 to
e2157ea
Compare
marekdedic
force-pushed
the
consistent-selector-style
branch
from
c066569 to
b1253f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #898