breaking: Redesigned ESLint config #957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 585c1f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
baseballyama
commented
Dec 14, 2024
| @@ -4,6 +4,7 @@ | |||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | |||
| "editor.codeActionsOnSave": { | |||
| "source.fixAll": "explicit", | |||
| "source.fixAll.eslint": "explicit", | |||
There was a problem hiding this comment.
ESLint fix didn’t work on save for some reason, but it started working after adding this.
| @@ -1,5 +1,5 @@ | |||
| import path from 'path'; | |||
| import { name, version } from '../package.json'; | |||
| import packageJson from '../package.json' assert { type: 'json' }; | |||
There was a problem hiding this comment.
To solve TypeScript error.
| @@ -9,7 +9,6 @@ void main(); | |||
| async function main() { | |||
| const { pluginsToRulesDTS } = await import('eslint-typegen/core'); | |||
|
|
|||
| // @ts-expect-error - types are a bit strict here | |||
There was a problem hiding this comment.
I don't get TypeScript error here.
baseballyama
force-pushed
the
breaking/update-config
branch
2 times, most recently
from
528bb28 to
01f686a
Compare
baseballyama
force-pushed
the
breaking/update-config
branch
from
006bd91 to
4395124
Compare
commit: |
|
I think #980 is better. |
These are mutually exclusive, do I understand that correctly? |
|
Yes, if we merge #980, I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte 5 and Svelte 4 have different features. Additionally, Svelte 5 introduces Runes mode and legacy mode, with some features marked as deprecated.
For a new project, rules related to deprecated features and legacy mode are likely unnecessary. While the Svelte version can be automatically determined from package.json, However ESLint cannot automatically detect whether deprecated features are being used without walking the AST.
Additionally, I personally dislike longer ESLint execution times caused by unnecessary rules, so I prefer to turn off unneeded rules at the configuration level. Configuring ESLint is a rare task, so even if some adjustments are required in the next major version, I believe it’s better to prioritize faster linting in daily workflows.
To address this, this PR provides the following three configurations:
Alternative of #943