fix: avoid creating update check timer on the server (#10015)

fixes #10005
sveltejs · May 23, 2023 · 81af6ba · 81af6ba
1 parent 1c1ddd5
commit 81af6ba
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/.changeset/serious-bulldogs-beam.md b/.changeset/serious-bulldogs-beam.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+fix: avoid creating update check timer on the server
diff --git a/packages/kit/src/runtime/client/singletons.js b/packages/kit/src/runtime/client/singletons.js
@@ -44,8 +44,8 @@ export function client_method(key) {
 }
 
 export const stores = {
-	url: notifiable_store({}),
-	page: notifiable_store({}),
-	navigating: writable(/** @type {import('types').Navigation | null} */ (null)),
-	updated: create_updated_store()
+	url: /* @__PURE__ */ notifiable_store({}),
+	page: /* @__PURE__ */ notifiable_store({}),
+	navigating: /* @__PURE__ */ writable(/** @type {import('types').Navigation | null} */ (null)),
+	updated: /* @__PURE__ */ create_updated_store()
 };
diff --git a/packages/kit/src/runtime/client/utils.js b/packages/kit/src/runtime/client/utils.js
@@ -219,15 +219,20 @@ export function notifiable_store(value) {
 export function create_updated_store() {
 	const { set, subscribe } = writable(false);
 
+	if (DEV || !BROWSER) {
+		return {
+			subscribe,
+			check: async () => false
+		};
+	}
+
 	const interval = __SVELTEKIT_APP_VERSION_POLL_INTERVAL__;
 
 	/** @type {NodeJS.Timeout} */
 	let timeout;
 
 	/** @type {() => Promise<boolean>} */
 	async function check() {
-		if (DEV || !BROWSER) return false;
-
 		clearTimeout(timeout);
 
 		if (interval) timeout = setTimeout(check, interval);