Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not crash server if specified ADDRESS_HEADER is missing from a request #10285

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

Conduitry
Copy link
Member

This fixes #10284 by moving the check for the presence of the header specified in ADDRESS_HEADER inside the getClientAddress function. The old behavior is that non-prerendered requests without the appropriate header will instantly crash the server. The new behavior is that getClientAddress() will throw an exception, like with the other checks.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2023

🦋 Changeset detected

Latest commit: 94b03c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 33d8f7b into sveltejs:master Jun 30, 2023
@github-actions github-actions bot mentioned this pull request Jun 30, 2023
@Conduitry Conduitry deleted the gh-10284 branch June 30, 2023 10:56
@bitdom8
Copy link

bitdom8 commented Jul 1, 2023

Hi, my server doesn't start now with old code on myserver.service: @Conduitry

ExecStart=sudo node -r dotenv/config build
WorkingDirectory=/usr/local/lsws/nodes/mynode/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node-adapted app crashes on request if referenced ADDRESS_HEADER is missing
4 participants