-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playground for development #10391
Conversation
|
I've personally never felt the need as I simply use the kit.svelte.dev site that's already checked in for testing, but I have no objection if others find it useful |
I've also sometimes used that, but since there is a lot going on there I find it can be harder to test stuff sometimes |
I'm in favor of this change. I use kit.svelte.dev often for this but if also often gets in the way with its prerendering pipeline so I delete stuff temporarily there. This would avoid that. |
this PR should probably update https://github.com/sveltejs/kit/blob/master/CONTRIBUTING.md. but otherwise lgtm |
I added a note in the contributing.md @benmccann RE: the types problem, is that just me? if not is there something we can do about it, or is it a "this is fine" situation? |
Maybe a good idea to also add a file with these contents: {
"pnpm": {
"overrides": {
"@sveltejs/kit": "../kit/packages/kit",
"@sveltejs/adapter-auto": "../kit/packages/adapter-auto",
"@sveltejs/adapter-cloudflare": "../kit/packages/adapter-cloudflare",
"@sveltejs/adapter-cloudflare-workers": "../kit/packages/adapter-cloudflare-workers",
"@sveltejs/adapter-netlify": "../kit/packages/adapter-netlify",
"@sveltejs/adapter-node": "../kit/packages/adapter-node",
"@sveltejs/adapter-static": "../kit/packages/adapter-static",
"@sveltejs/adapter-vercel": "../kit/packages/adapter-vercel"
}
}
} so that there's an easily accessible copypasta when cloning repros. Not sure if there's a better place for it outside the playground folder |
We already have it in the CONTRIBUTING.md so maybe there? Though not sure if we would want to have a list of all packages imo |
If I understood the description correctly, Geoff's PR to generate the types on postinstall should've fixed the types issue. |
Yep #10301 fixed that problem! Though I do wonder if we should watch for changes - at any rate the playground itself is good to go |
Should we put this into |
The main reason I put it in packages to align with svelte and other monorepo setups in the ecosystem |
|
I like the idea of putting it in the root directory |
I think I like @dummdidumm's suggestion of putting it in |
My only worry is that it'll be tucked away - and while it literally is a site, it's not really a site in the way I imagine that folder was intended. Putting it in packages has always felt weird to me but I have done it as that's what others done, but if vite is putting it at the root that would be my new preferred solution |
In the Svelte 5 codebase we have a few playgrounds that we just moved under a |
tracking in CONTRIBUTING.md
In the Svelte repo we have a playground for locally testing changes, but we don't here - this adds that. WDYT?
My main issue currently is that there are no types for most modules
@sveltejs/kit
,$app/stores
, etc... I believe this is due to thegenerate-dts
script not being run till kit is released - I don't know the best way to fix this. It's also an issue in the other packages so it's not an issue introduced by this pr from what I can tell.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.