-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass external
to esbuild in the Cloudflare adapters
#10424
Conversation
🦋 Changeset detectedLatest commit: 3c767a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Oh, I didn't check the PRs before 😅 At least, there seems to be a need. |
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
I've applied the requested changes and rebased onto the latest master. |
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
documentation/docs/25-build-and-deploy/60-adapter-cloudflare.md
Outdated
Show resolved
Hide resolved
documentation/docs/25-build-and-deploy/70-adapter-cloudflare-workers.md
Outdated
Show resolved
Hide resolved
} | ||
}; | ||
``` | ||
|
||
### Custom config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I change this one to config
as well, like:
### Custom config | |
### `config` |
That would be consistent with the other file, IMO.
Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: Ben McCann <[email protected]>
Closing this in favor of #10521 |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Some external modules rely on NodeJS modules, such as
fs
. This causes problems duringnpm run build
, even if my code does not rely on the respective code-path that requires any problematic modules (likefs
). For me, this is the case with ical-generator.This change is inspired by the already existing functionality in the Vercel adapter, that accomplished the same:
kit/packages/adapter-vercel/index.d.ts
Lines 56 to 75 in b251b23
Respectively:
kit/packages/adapter-vercel/index.js
Lines 111 to 124 in b251b23
The only related issue that I've found was #6547, which was resolved because Stripe changed their implementation. This is the ideal resolution, I admit, but the world is not ideal as far as I'm concerned.