Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make output reflect user's choice of package manager #10811

Merged
merged 29 commits into from
Oct 4, 2023

Conversation

the-r3aper7
Copy link
Contributor

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

🦋 Changeset detected

Latest commit: 2dffc11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

This seems like a good idea, but I wonder if we want to add an extra library for such a simple piece of functionality. Maybe it'd be preferable to just copy the source?

https://github.com/zkochan/packages/blob/main/which-pm-runs/index.js

@the-r3aper7
Copy link
Contributor Author

yeah its a good idea, how should i provide the credits for the code from that package?

@benmccann
Copy link
Member

You could just add a comment linking back to the original in the place where the code is added

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kit-default-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 5:12pm

@vercel
Copy link

vercel bot commented Oct 4, 2023

@the-r3aper7 is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@the-r3aper7
Copy link
Contributor Author

the-r3aper7 commented Oct 4, 2023

@benmccann can you review this?
shall i add another functionality for initializing git option in cli WDYT?

@benmccann
Copy link
Member

thanks for catching that issue @Conduitry! I fixed it and made some other improvements before merging

@github-actions github-actions bot mentioned this pull request Oct 4, 2023
@the-r3aper7 the-r3aper7 deleted the dynamic-pkg-manager branch October 5, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants