-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make output reflect user's choice of package manager #10811
Conversation
🦋 Changeset detectedLatest commit: 2dffc11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This seems like a good idea, but I wonder if we want to add an extra library for such a simple piece of functionality. Maybe it'd be preferable to just copy the source? https://github.com/zkochan/packages/blob/main/which-pm-runs/index.js |
yeah its a good idea, how should i provide the credits for the code from that package? |
You could just add a comment linking back to the original in the place where the code is added |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@the-r3aper7 is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
@benmccann can you review this? |
thanks for catching that issue @Conduitry! I fixed it and made some other improvements before merging |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.