Revert "fix: build service workers in IIFE format" #11400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5f052a3.
🦋 Changeset detectedLatest commit: c59be9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I agree it'd be nice to fix upstream, but I thought this workaround could unblock people in the meantime. If we need the fix to be in esbuild it may take a long time because I don't know Go and Vite would then need to adopt that version |
|
Oh, I see. There's another workaround. How about tacking that onto this PR? I'm fine with reverting this assuming the other solution works |
benmccann
reviewed
Dec 19, 2023
benmccann
reviewed
Dec 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11129 — there's a better workaround that doesn't result in an IIFE wrapper