-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup #10979 #11641
chore: cleanup #10979 #11641
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - @Rich-Harris maybe you want to give this another look since it's about enhancing the adapter API.
I left some comments on the other PR. I don't think we've got the right API yet. Unfortunately I'm off today so can't weigh in much more than that, so if we want to merge the release PR we should probably revert #10979 for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving a 'request changes' making sure we don't merge this in the meantime
I’ve created a PR to revert the changes here #11644 in case we can't clean it up in time for a next release |
cleans up #10979 by implementing the feedback from after the PR was merged for the issue #10594
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits