Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up emulator types #11737

Merged
merged 3 commits into from
Jan 25, 2024
Merged

chore: clean up emulator types #11737

merged 3 commits into from
Jan 25, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jan 25, 2024

  • the Emulator type is not a class export
  • make validated config types more correct by leaving adapter types as optional

Leftovers from #11730, no changeset because the thing is not released yet.
Through this I noticed that export class Server is similarly incorrect; I guess it just doesn't matter really in practise because only adapters use that for their types.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

- the Emulator type is not a class export
- make validated config types more correct by leaving adapter types as optional
Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: 19a7eca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 440a546 into main Jan 25, 2024
13 checks passed
@Rich-Harris Rich-Harris deleted the emulator-types-cleanup branch January 25, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants