-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle redirect thrown from root layout load when client-side navigating to a non-existent page #12005
Merged
+54
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bacbe5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
eltigerchino
changed the title
fix: handle root layout redirect when navigating to a non-existent page in a SPA
fix: handle universal root layout redirect for client-side navigation to a non-existent page
Mar 19, 2024
eltigerchino
changed the title
fix: handle universal root layout redirect for client-side navigation to a non-existent page
fix: handle redirect thrown from root layout load when client-side navigating to a non-existent page
Mar 22, 2024
dummdidumm
approved these changes
Jan 13, 2025
preview: https://svelte-dev-git-preview-kit-12005-svelte.vercel.app/ this is an automated message |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11099
There is currently no client-side error handling logic for when we run the root layout load function from rendering the root error page. This catches and handles the unhandled thrown Redirect.
Note: we should be displaying a static fallback page for any other type of error but I'm not sure how to do that client-side (the function already exists but only for the server).
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits