Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary tslib dependency #12453

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

fcrozatier
Copy link
Contributor

tslib was added to the Svelte codebase in sveltejs/svelte#920 but the --importHelpers option since disappeared from the tsconfig during the split in sveltejs/svelte#2994. This option as well as downlevelling are also not set by create-svelte.

So this library is unused, and there is no need to keep it. This PR removes it.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x ] This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • [ x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 45d57f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann changed the title Remove tslib fix: remove unnecessary tslib dependency Jul 8, 2024
@benmccann benmccann requested a review from dummdidumm July 8, 2024 18:15
@dummdidumm
Copy link
Member

Thanks! @benmccann I noticed that the create-vite template also have the dependency needlessly, I think we can remove it there, too

@dummdidumm dummdidumm merged commit 6f15fe4 into sveltejs:main Jul 9, 2024
11 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
@fcrozatier fcrozatier deleted the tslib branch July 9, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants