fix: allow dynamic routes with missing fallback in hash mode #13213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d22baa0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
preview: https://svelte-dev-git-preview-kit-13213-svelte.vercel.app/ this is an automated message |
|
self-merging as this is blocking a launch |
Merged
dummdidumm
reviewed
Dec 21, 2024
| @@ -7,7 +7,7 @@ export default function (options) { | |||
| name: '@sveltejs/adapter-static', | |||
|
|
|||
| async adapt(builder) { | |||
| if (!options?.fallback) { | |||
| if (!options?.fallback && builder.config.kit.router.type !== 'hash') { | |||
There was a problem hiding this comment.
This breaks everyone not on the latest version of kit, needs to use optional chaining for the type part
There was a problem hiding this comment.
ah shit, this is what i get for trying to get stuff launched while distracted on a train with only a dwindling cellphone hotspot for connectivity. will open a PR
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, apps with
router.type === 'hash'will fail to build withadapter-staticPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits