Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode URL before navigating when hash router is enabled #13321

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Jan 16, 2025

fixes #13318

This PR decodes the URL when the hash router is enabled and the user enters the URL through the browser address bar (during app initialisation and the hashchange event). We need to do this because Safari seems to encode any extra hashes in the URL (only when accessed through the file protocol?). So, entering /#/#about in the address bar becomes /#/%23about which the client router incorrectly thinks is a route instead of just an ID.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 72586fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13321-svelte.vercel.app/

this is an automated message

@dummdidumm dummdidumm merged commit a91ba1f into main Jan 16, 2025
14 checks passed
@dummdidumm dummdidumm deleted the fix-safari-hash-router branch January 16, 2025 08:52
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
@stephenlrandall
Copy link
Contributor

@eltigerchino How would this work with a URL like .../index.html?q=%231#/search? Would the decoding cause the hash to be interpreted incorrectly?

@eltigerchino
Copy link
Member Author

eltigerchino commented Jan 17, 2025

@eltigerchino How would this work with a URL like .../index.html?q=%231#/search? Would the decoding cause the hash to be interpreted incorrectly?

Good point. It probably wouldn't work since it decodes the entire URL instead of just the hash segment. I'll work on a fix.

EDIT: here's the PR with the fix #13332

dummdidumm pushed a commit that referenced this pull request Jan 17, 2025
followup to #13321 / #13316

This PR ensures only the hash of the URL is decoded so that any encoded hash character in the query parameters remains encoded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 when loading inline app with hash in URL (Safari only)
4 participants