Fix examples #170
Merged
Fix examples #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
fix-examples
branch
from
bd1087e to
9e0b36d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #92 (CC @ehrencrona). I couldn't find
getStoresanywhere in the build. I thinkemitDeclarationOnly: trueprobably is not the right thing to be doing. I wasn't quite sure how this was all intended to work, but I think that just getting things working again is a good first step and then we can try to re-enable things when we have some quality control checks. Building the examples is working for me locally, but failing on the CI for some reason, so I guess that will have to be a follow up PR to figure out what's going onOne of the main things I'd want people to check is to see if
import { stores } from '/_app/main/client';being changed toimport { getStores } from '/_app/main/runtime/stores';is the intended thing to do (we might consider renaminggetStoresback tostores, which I think is more concise and more backwards compatible with Sapper and is probably the #1 question I see people asking about on Discord)The Real World example is still broken, but the other three are working. I'm not quite sure how to fix the import paths for that project, but I think it shouldn't be too hard to figure out for someone who's a bit more familiar with things now that this has everything building again