[docs] updated Netlify adapter documentation to include AWS_LAMBDA_JS_RUNTIME (closes #2687)

[accuser]

Netlify defaults to using Node.js 12 as the runtime for JavaScript functions, but this version is no longer supported by SvelteKit, as noted in #2687. I have added the AWS_LAMBDA_JS_RUNTIME setting to the documentation for the Netlify adapter.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2509e03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[benmccann]

I wonder if rather than updating the docs, we can use Netlify's framework detector to specify Node 14 if not otherwise specified?

https://github.com/netlify/framework-info/blob/main/src/frameworks/svelte-kit.json

[benmccann]

We could also set the NODE_VERSION like Nuxt does to make it so that you don't have to set that in an .nvmrc, etc.

https://github.com/netlify/framework-info/blob/39f9e3fff4370a23f1d62f76cc07bfda3b20e59b/src/frameworks/nuxt3.json#L19
https://docs.netlify.com/configure-builds/manage-dependencies/#node-js-and-javascript

[benmccann]

PR for framework-info here: netlify/framework-info#553

Let's leave this one open for the time being until we get a response on that one and test it out

[accuser]

PR for framework-info here: netlify/framework-info#553

Let's leave this one open for the time being until we get a response on that one and test it out

This makes sense until the PR for the Netlify framework detector is accepted.

[ascorbic]

Unfortunately this won't work right now, but we're working on it, and nor will the framework detection code. I made a mistake when I added the Nuxt env vars so you can't use that approach. They're actually only used when running netlify dev, which I misunderstood. The good news is that we will very shortly be switching the default Lambda runtime to 14, and this issue has moved that up the priority list.

The current correct solution is to set AWS_LAMBDA_JS_RUNTIME in the site UI, not in the toml.

[benmccann]

Oops, I missed the comment that this won't work: #2715 (comment)

Closing as a result of that comment