replace request.origin/path/query with request.url

[Rich-Harris]

This is a substantial breaking change, but a welcome one — it simplifies things a bit. It replaces request.origin, request.path and request.query with a single request.url, which is a standard URL object.

Similarly, page load functions now take a { url, params, ... } object rather than { page, ... }, and the page store contains { url, params }.

@Conduitry suggested we take this opportunity to rethink the naming of params, though I haven't had any particularly great ideas for what to rename it to.

Closes #3078.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2126c04

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Conduitry]

I didn't have any great ideas of what to rename params to either, unfortunately. My concern was that, since it was no longer part of the $page store and no longer alongside other URL-y things, the name params would be a bit vague. I had half-heartedly suggested slugs but Rich wasn't any more thrilled with that one than I was.

[Rich-Harris]

Still to do:

• fix the one remaining broken test (change detection for load functions is less granular than previously — need to either make it more granular, or change the test)
• docs
• add getters on the request/load arguments so that people currently using path, query and origin understand why their app broke

[silentworks]

@Rich-Harris I know this is closed but am I correct in thinking the original statement of ...and the page store has been replaced with url and params stores no longer applies since it seems page store still exists in the latest version?

[Rich-Harris]

Yep, classic case of the comments not matching the code. Last-minute bikeshedding