Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] adding returned stuff from pages to $page store #3252

Merged
merged 6 commits into from
Jan 10, 2022

Conversation

tanhauhau
Copy link
Member

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2022

🦋 Changeset detected

Latest commit: f8d82f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 9, 2022

❌ Deploy Preview for kit-demo failed.

🔨 Explore the source changes: 6660196

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61dad215255cd1000813ba4a

@benmccann benmccann changed the title adding returned stuff from pages to $page store [feat] adding returned stuff from pages to $page store Jan 9, 2022
@benmccann benmccann linked an issue Jan 9, 2022 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jan 10, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: f8d82f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61dca601d7340d0007f78cea

@PuruVJ
Copy link
Contributor

PuruVJ commented Jan 11, 2022

Kudos naming it stuff 🤣👍

@gterras
Copy link

gterras commented Jan 14, 2022

Thanks for this game changer feature 👍

@ggjersund
Copy link

ggjersund commented Jan 22, 2022

@tanhauhau I just started learning Svelte using Svelte-kit and I came across this issue with passing stuff from a child route to a parent layout file. I'm trying to pass a Load Error to a parent error file from the following path:
src/routes/admin/index.svelte -> src/routes/__error.svelte.

Should this work in you're case? or Do I have some sort of wrong implementation here? The error and status gets received by the parent _error page correctly, but not the stuff property.

<script context="module" lang="ts">
  export const load = async ({ params , fetch }) => {
    // Just triggering an error here for testing
    const url = `/admin/${params.index}.json`;
    const res = await fetch(url);
    if (res.ok) {
      return {
        props: {
          article: await res.json()
        }
      };
    }

    return {
      status: res.status,
      error: new Error(`Failed to find ${url}`),
      stuff: {
        page: "Admin"
      }
    };
  }
</script>

and then stuff should be retrievable from a parent __error.svelte page like this?

<script lang="ts">
    import { page } from '$app/stores';
</script>

<svelte:head>
  <title>ERROR PAGE</title>
</svelte:head>

<main>
  <h1>Failed to find {JSON.stringify($page.stuff)}</h1>
  <p>{`${$page.status}: ${$page.error.message}`}</p>
</main>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page metadata
6 participants