Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write generated types to __types directories #4705

Merged
merged 10 commits into from
May 19, 2022
Merged
Prev Previous commit
Next Next commit
fix tests
Rich-Harris committed May 18, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 8543179091e2e82afa1df11d6da88faa814a6eec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
/**
* @type {import('./__types/foo').Foo}
* @type {import('./foo').Foo}
*/
export let foo;
</script>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
/**
* @type {import('./__types/foo').Foo}
* @type {import('./foo').Foo}
*/
export let foo;
</script>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
/**
* @type {import('./__types/foo').Foo}
* @type {import('./foo').Foo}
*/
export let foo;
</script>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
/**
* @type {import('./__types/foo').Foo}
* @type {import('./foo').Foo}
*/
export let foo;
</script>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
/**
* @type {import('./__types/foo').Foo}
* @type {import('./foo').Foo}
*/
export let foo;
</script>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
/**
* @type {import('./__types/foo').Foo}
* @type {import('./foo').Foo}
*/
export let foo;
</script>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
/**
* @type {import('./__types/foo').Foo}
* @type {import('./foo').Foo}
*/
export let foo;
</script>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
/**
* @type {import('./__types/foo').Foo}
* @type {import('./foo').Foo}
*/
export let foo;
</script>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
/**
* @type {import('./__types/foo').Foo}
* @type {import('./foo').Foo}
*/
export let foo;
</script>
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
/**
* @type {import('./__types/foo').Foo}
* @type {import('./foo').Foo}
*/
export let foo;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These also seem unrelated, but possibly ok to keep because else prettier complains (?)

</script>
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<script>
/** @type {import('./__types/foo').Foo} */
/** @type {import('./foo').Foo} */
export let foo;
</script>
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<script>
/** @type {import('./__types/foo').Foo} */
/** @type {import('./foo').Foo} */
export let foo;
</script>
1 change: 1 addition & 0 deletions packages/kit/src/packaging/test/watch/src/lib/Test.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<script lang="ts">export let answer: number</script>
1 change: 1 addition & 0 deletions packages/kit/src/packaging/test/watch/src/lib/a.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const a = "a";
1 change: 1 addition & 0 deletions packages/kit/src/packaging/test/watch/src/lib/b.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const b = "b";