Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double-mount bug #4891

Merged
merged 12 commits into from
May 25, 2022
Merged

Fix double-mount bug #4891

merged 12 commits into from
May 25, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented May 12, 2022

Stumbled upon a nasty bug while investigating #4864 — if you edit src/routes/a/[b].svelte, then any navigation from /a/1 to /a/2 will cause [b].svelte to be reloaded (with the HMR cache-busting timestamp), then unmounted and remounted.

I think the reason is that we have an import('/src/routes/[b].svelte') in the HTML and in the routes manifest; the latter import is cachebusted but the one in the HTML isn't.

This only occurs during dev.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2022

🦋 Changeset detected

Latest commit: d402526

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris changed the title add failing test for double-mount bug Fix double-mount bug May 12, 2022
@Rich-Harris Rich-Harris marked this pull request as ready for review May 12, 2022 21:11
@Rich-Harris
Copy link
Member Author

The reason this is failing CI is that changing how the initial page components are loaded has surfaced an unrelated bug: vitePreload fails in svelte-kit preview if paths.assets is specified, because in preview we replace it with /_svelte_kit_assets in order to serve assets locally. Previously the bug was masked (at least in the tests) because the components were already loaded via import(...) and <link>, meaning the router didn't try to load them via vitePreload.

This will hopefully be fixed by vitejs/vite#7644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant