Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use separate ignore files for prettier and eslint #5009

Merged
merged 1 commit into from
May 21, 2022
Merged

use separate ignore files for prettier and eslint #5009

merged 1 commit into from
May 21, 2022

Conversation

brian14708
Copy link
Contributor

Use separate ignore files for prettier and eslint.

Fixes #4937

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2022

🦋 Changeset detected

Latest commit: 65bb6d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brian14708 brian14708 marked this pull request as ready for review May 21, 2022 05:02
@Rich-Harris Rich-Harris merged commit cb3c5ec into sveltejs:master May 21, 2022
@Rich-Harris
Copy link
Member

thank you!

@benmccann
Copy link
Member

Ignoring the lock files makes sense, but do we want to ignore package.json as well? Maybe that one could be checked / formatted

@brian14708 brian14708 deleted the separate-ignore-files branch May 21, 2022 13:35
@brian14708
Copy link
Contributor Author

Ignoring the lock files makes sense, but do we want to ignore package.json as well? Maybe that one could be checked / formatted

ignored package.json because it wasn't formatted correctly be default.

attempt fix in #5013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier formats lockfiles
3 participants