-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Use ESM eslint config files" #5293
Conversation
This reverts commit 500067b.
🦋 Changeset detectedLatest commit: 92ca048 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
You'd need to create a new changeset, not delete the old one, in order for this to be released properly after it's merged. That said, can you be more specific about "does not seem to work"? |
I added a changeset. The following is the result of creating a new app with Oops! Something went wrong! :(
ESLint: 8.18.0
Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/Development/my-app/.eslintrc.js from /Users/Development/my-app/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs not supported.
Instead change the require of .eslintrc.js in /Users/Development/my-app/node_modules/.pnpm/@[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs to a dynamic import() which is available in all CommonJS modules. |
Can confirm and replicate. The docs also state:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh goodness. I swear I tested this, but you're right and I'm seeing the same behavior. I'm not sure what happened
thanks for sending the fix
Reverts #5263
Unfortunately, this does not seem to work.
Result of running
pnpm lint