Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSP reportOnly mode #5496

Merged
merged 16 commits into from
Jul 13, 2022
Merged

CSP reportOnly mode #5496

merged 16 commits into from
Jul 13, 2022

Conversation

Rich-Harris
Copy link
Member

this is #5078, but without the permission gremlins

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022

🦋 Changeset detected

Latest commit: 8cc6474

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

i can't technically approve this PR since i'm the 'author', but since @tcc-sejohnson did all the actual work i'm going to abuse my admin privileges and 'approve' it anyway — thanks @tcc-sejohnson!

@Rich-Harris
Copy link
Member Author

oh wait, we just disabled the ability for admins to push directly to master...

@Rich-Harris Rich-Harris merged commit a91a52c into master Jul 13, 2022
@Rich-Harris Rich-Harris deleted the gh-3556 branch July 13, 2022 17:00
@elliott-with-the-longest-name-on-github
Copy link
Contributor

Thanks Rich! I was just in the process of trying to unwind those commits and fix the permissions when I saw this.

@Rich-Harris Rich-Harris mentioned this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants