-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] transform links to be absolute to avoid console error when navigating #5583
Conversation
🦋 Changeset detectedLatest commit: 275d788 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
absolutely bewildered by these safari failures |
Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a begrudging approval 😄 I hate that we have to do this, but it seems like the best course of action
wow. per 91049b7, this change really is responsible for those persistent failures. what the actual fucking hell, safari |
This reverts commit 91049b7.
ok, so it turns out that changing certain link hrefs causes scrolling to go batshit in safari. it turns out that if we only update |
@Magkoooh please don't approve already merged PRs as it just creates spam for the maintainers |
fixes #3748.
This doesn't have a test because I haven't been able to observe this behaviour with anything other than a(actually, we can test that link hrefs are absolute)<link rel="icon">
(and in any browser other than Chrome), and favicons are loaded somewhat unpredictably.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0