Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] transform links to be absolute to avoid console error when navigating #5583

Merged
merged 15 commits into from
Jul 20, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jul 18, 2022

fixes #3748. This doesn't have a test because I haven't been able to observe this behaviour with anything other than a <link rel="icon"> (and in any browser other than Chrome), and favicons are loaded somewhat unpredictably. (actually, we can test that link hrefs are absolute)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2022

🦋 Changeset detected

Latest commit: 275d788

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

absolutely bewildered by these safari failures

@benmccann benmccann changed the title make link hrefs absolute [fix] transform links to be absolute to avoid console error when navigating Jul 19, 2022
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a begrudging approval 😄 I hate that we have to do this, but it seems like the best course of action

@Rich-Harris
Copy link
Member Author

wow. per 91049b7, this change really is responsible for those persistent failures. what the actual fucking hell, safari

@Rich-Harris
Copy link
Member Author

ok, so it turns out that changing certain link hrefs causes scrolling to go batshit in safari. it turns out that if we only update link[rel=icon] everything works fine, and since the chrome bug only relates to those links, we should be fine. man, browsers are a mess

@benmccann
Copy link
Member

@Magkoooh please don't approve already merged PRs as it just creates spam for the maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SvelteKit loads favicon every page request and messes up the request
3 participants