Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send validation errors as props when rendering page in the client #5913

Closed
wants to merge 2 commits into from
Closed

fix: send validation errors as props when rendering page in the client #5913

wants to merge 2 commits into from

Conversation

pilcrowonpaper
Copy link

Fixes #5906

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2022

🦋 Changeset detected

Latest commit: cdfb829

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Thank you, but this doesn't actually fix the bug, therefore closing.

@dummdidumm dummdidumm closed this Aug 16, 2022
@pilcrowonpaper
Copy link
Author

pilcrowonpaper commented Aug 16, 2022

Actually tested the new package (ran it inside /test/apps) and it fixed the reproduction I made for the issue.

@dummdidumm Can you elaborate on "doesn't actually fix the bug"? Does it mean the PR doesn't do anything at all, or does it mean it doesn't fix the root problem?

@dummdidumm
Copy link
Member

I added a test to check the behavior, and the test failed with and without the fix - so did your minimum reproducible on the issue. Furthermore the props property isn't read anywhere on the client AFAIK, so I'm not sure why it fixed things for you.

@pilcrowonpaper
Copy link
Author

Found my mistake (I mean looking back at the code, it doesn't make sense). SvelteKit was throwing an error, causing the hydration to not occur. I see an error in the browser console but I don't remember seeing it yesterday. Sorry about that!

@pilcrowonpaper pilcrowonpaper deleted the fix--send-vaidation-errors-as-props branch August 16, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errors exported by +page.svelte is only available on the server and not on the client
2 participants