-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle non-prod dependencies with esbuild #6372
Conversation
🦋 Changeset detectedLatest commit: cf6bfa2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It's probably worth adding something to the |
Also maybe a general note explaining the difference since it's less obvious than a common node project, like the Sapper docs did. |
What about minification of the entire server part and bundling of prod dependencies? |
There's really nothing to be gained from minifying server-side code except making it harder to debug. As the README says, if you want a dependency to be bundled, move it to devDependencies |
My build weighs 120 MB, which is 3 times more than node 16 alpine. It's sad. You can make minification optional. |
This closes #3176, by always bundling dev dependencies using
esbuild
. Supersedes #6301.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0