prefer JSON error responses over HTML in fetch case #6497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1931.
Today, if you have a route like this...
...then visiting
/error
will show you the fallback error page:If you
fetch
the page with anapplication/json
header, you'll get a JSON representation of the error......but by default
fetch
will get HTML. In most cases that's probably not that helpful.This PR reverses the precedence during content negotiation, so that if a request has an
accept: */*
header (whichfetch
requests do, by default) it will prefer JSON to HTML.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0