Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only forward cookies for internal fetches - #6923

Merged
merged 1 commit into from
Sep 21, 2022
Merged

only forward cookies for internal fetches - #6923

merged 1 commit into from
Sep 21, 2022

Conversation

Rich-Harris
Copy link
Member

closes #6604.

I'm not sure if we also need to handle the case where www.domain.com is requesting data from domain.com, or where the external origin sets a third party cookie?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re domain vs www.domain - I vaguely remember that these are treated differently, so this should be correct.
Re third party cookies: How can these be detected? From a quick reading it sounds like they should be forwarded since they are not related to your domain.

Approving to get you unblocked.

@Rich-Harris Rich-Harris merged commit 73ea7b4 into master Sep 21, 2022
@Rich-Harris Rich-Harris deleted the gh-6604 branch September 21, 2022 19:42
This was referenced Sep 21, 2022
@oetiker
Copy link

oetiker commented Sep 22, 2022

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie leak
3 participants