-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] allow missing routes folder #6944
Conversation
🦋 Changeset detectedLatest commit: cf82821 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
||
if (!root.layout?.component) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub diff fucks this up - nothing changed here except moving the error message into the if block, the rest is just indentation difference
errr i guess i rescind my approval until the tests pass 😅 |
id: '', | ||
pattern: '/^$/' | ||
} | ||
]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test shows that nodes for the root layout and error are created. This means that the running code later on can safely assume these to be always present. Before that, the manifest was generated without these, causing dev
and build
to fail with "cannot read properties of nodes[0].component" or sth like that. Adding the default nodes even in case of a missing routes folder seems like the better option, even if it seems somewhat strange at first. I'll add a comment to the manifest about this.
Fixes #6921
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0