Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] allow missing routes folder #6944

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Conversation

dummdidumm
Copy link
Member

Fixes #6921

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022

🦋 Changeset detected

Latest commit: cf82821

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR


if (!root.layout?.component) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub diff fucks this up - nothing changed here except moving the error message into the if block, the rest is just indentation difference

@Rich-Harris
Copy link
Member

errr i guess i rescind my approval until the tests pass 😅

id: '',
pattern: '/^$/'
}
]);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test shows that nodes for the root layout and error are created. This means that the running code later on can safely assume these to be always present. Before that, the manifest was generated without these, causing dev and build to fail with "cannot read properties of nodes[0].component" or sth like that. Adding the default nodes even in case of a missing routes folder seems like the better option, even if it seems somewhat strange at first. I'll add a comment to the manifest about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the routes folder to be empty
2 participants