Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use internal alias that won't collide with user aliases #9022

Merged
merged 5 commits into from
Feb 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/long-paws-judge.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: use internal alias that won't collide with user aliases
2 changes: 1 addition & 1 deletion packages/kit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"postinstall.js"
],
"scripts": {
"lint": "prettier --check . --config ../../.prettierrc --ignore-path .gitignore && eslint src/**",
"lint": "prettier --check . --config ../../.prettierrc --ignore-path .gitignore && eslint src/**/*.js",
"check": "tsc",
"check:all": "tsc && pnpm -r --filter=\"./**\" check",
"format": "prettier --write . --config ../../.prettierrc --ignore-path .gitignore",
Expand Down
6 changes: 4 additions & 2 deletions packages/kit/src/exports/vite/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ function kit({ svelte_config }) {

async resolveId(id) {
// treat $env/static/[public|private] as virtual
if (id.startsWith('$env/') || id === '$internal/paths' || id === '$service-worker') {
if (id.startsWith('$env/') || id === '@sveltejs/kit/paths' || id === '$service-worker') {
return `\0${id}`;
}
},
Expand Down Expand Up @@ -358,7 +358,9 @@ function kit({ svelte_config }) {
);
case '\0$service-worker':
return create_service_worker_module(svelte_config);
case '\0$internal/paths':
// for internal use only. it's published as $app/paths externally
// we use this alias so that we won't collide with user aliases
case '\0@sveltejs/kit/paths':
const { assets, base } = svelte_config.kit.paths;
return `export const base = ${s(base)};
export let assets = ${assets ? s(assets) : 'base'};
Expand Down
6 changes: 6 additions & 0 deletions packages/kit/src/internal.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/** Internal version of $app/paths */
declare module '@sveltejs/kit/paths' {
export const base: `/${string}`;
export let assets: `https://${string}` | `http://${string}`;
export function set_assets(path: string): void;
}
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/app/paths.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { base, assets } from '$internal/paths';
export { base, assets } from '@sveltejs/kit/paths';
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/client/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import { parse } from './parse.js';

import Root from '__GENERATED__/root.svelte';
import { nodes, server_loads, dictionary, matchers, hooks } from '__CLIENT__/manifest.js';
import { base } from '$internal/paths';
import { base } from '@sveltejs/kit/paths';
import { HttpError, Redirect } from '../control.js';
import { stores } from './singletons.js';
import { unwrap_promises } from '../../utils/promises.js';
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/client/utils.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { BROWSER, DEV } from 'esm-env';
import { writable } from 'svelte/store';
import { assets } from '$internal/paths';
import { assets } from '@sveltejs/kit/paths';
import { version } from '../shared.js';
import { PRELOAD_PRIORITIES } from './constants.js';

Expand Down
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/server/fetch.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as set_cookie_parser from 'set-cookie-parser';
import { respond } from './respond.js';
import * as paths from '$internal/paths';
import * as paths from '@sveltejs/kit/paths';

/**
* @param {{
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/server/page/render.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as devalue from 'devalue';
import { readable, writable } from 'svelte/store';
import { DEV } from 'esm-env';
import { assets, base } from '$internal/paths';
import { assets, base } from '@sveltejs/kit/paths';
import { hash } from '../../hash.js';
import { serialize_data } from './serialize_data.js';
import { s } from '../../../utils/misc.js';
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/server/respond.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { DEV } from 'esm-env';
import { base } from '$internal/paths';
import { base } from '@sveltejs/kit/paths';
import { is_endpoint_request, render_endpoint } from './endpoint.js';
import { render_page } from './page/index.js';
import { render_response } from './page/render.js';
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/shared.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export { set_assets } from '$internal/paths';
export { set_assets } from '@sveltejs/kit/paths';

export let building = false;
export let version = '';
Expand Down
7 changes: 0 additions & 7 deletions packages/kit/types/ambient.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -438,10 +438,3 @@ declare module '@sveltejs/kit/vite' {
export function sveltekit(): Promise<Plugin[]>;
export { vitePreprocess } from '@sveltejs/vite-plugin-svelte';
}

/** Internal version of $app/paths */
declare module '$internal/paths' {
export const base: `/${string}`;
export let assets: `https://${string}` | `http://${string}`;
export function set_assets(path: string): void;
}
2 changes: 1 addition & 1 deletion sites/kit.svelte.dev/src/lib/docs/server/render.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export function replace_placeholders(content) {

let import_block = '';

if (module.exports.length > 0 && !module.name.startsWith('$internal')) {
if (module.exports.length > 0) {
// deduplication is necessary for now, because of `error()` overload
const exports = Array.from(new Set(module.exports.map((x) => x.name)));

Expand Down