Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist DOM state on beforeunload #9345

Merged
merged 1 commit into from
Mar 8, 2023
Merged

persist DOM state on beforeunload #9345

merged 1 commit into from
Mar 8, 2023

Conversation

Rich-Harris
Copy link
Member

closes #9098. Since we're already using beforeunload, there's no real reason not to persist state there as well. This does mean that non-Firefox browsers will persist the state twice, but... that's probably fine?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@Rich-Harris Rich-Harris changed the title persist DOM state on beforeunload - persist DOM state on beforeunload Mar 6, 2023
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9098 (comment) makes me wonder if we should dynamically add/remove beforeunload listeners as it hurts bfcache (only on Firefox, but still) if it's set.

@dummdidumm dummdidumm merged commit 0f863bb into master Mar 8, 2023
@dummdidumm dummdidumm deleted the gh-9098 branch March 8, 2023 13:33
@github-actions github-actions bot mentioned this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshots are saved when tab becomes hidden, not when it is unloaded
2 participants