Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter-node): only send cache header when static resource is 200 #9394

Merged
merged 4 commits into from
Mar 15, 2023
Merged

fix(adapter-node): only send cache header when static resource is 200 #9394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f14ed6
Only send cache header when static resource is 200 #9393
cdemi Mar 10, 2023
3787780
Added changeset
cdemi Mar 10, 2023
31535fa
Prettified adapter-node
cdemi Mar 10, 2023
43f37af
Update .changeset/khaki-schools-invent.md
cdemi Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/khaki-schools-invent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-node': patch
---

fix: only send cache header when static resource is 200
2 changes: 1 addition & 1 deletion packages/adapter-node/src/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function serve(path, client = false) {
client &&
((res, pathname) => {
// only apply to build directory, not e.g. version.json
if (pathname.startsWith(`/${manifest.appPath}/immutable/`)) {
if (pathname.startsWith(`/${manifest.appPath}/immutable/`) && res.statusCode === 200) {
res.setHeader('cache-control', 'public,max-age=31536000,immutable');
}
})
Expand Down