reload after error #9441
reload after error #9441
Conversation
🦋 Changeset detectedLatest commit: b8e6860 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| if (import.meta.hot) { | ||
| import.meta.hot.on('vite:beforeUpdate', () => { | ||
| if (errored) { | ||
| location.reload(); |
There was a problem hiding this comment.
should we add something here like console.warn('Hit an unrecoverable error. Reloading the page')?
There was a problem hiding this comment.
no-one would see the message, because the page would reload the moment it was logged. we could add it when errored is set to true though
There was a problem hiding this comment.
I think by default that's true, but I believe there's a checkbox you can toggle to persist it across a page navigation and I thought people might try that if they were confused why the reload was happening
There was a problem hiding this comment.
Yeah I have this turned on by default in my dev profile. Might be a nice addition in retrospect.
It's quite hard to get SvelteKit into an unrecoverably broken state during dev — to the extent that I can't reliably reproduce it — but it's not impossible. learn.svelte.dev seems particularly prone to it, due to some quirk of the setup, though I've seen it happen in a normal project too.
This seems like a pretty comprehensive fix: if something causes an unexpected error, reload the page on the next HMR event. learn.svelte.dev is noticeably more reliable with this change.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.