Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize svelte-check bundle size #2544

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: optimize svelte-check bundle size
jasonlyu123 committed Oct 24, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 95279c09ba1249ee3c9a43ceb13bd947ade7464e
3 changes: 2 additions & 1 deletion packages/language-server/package.json
Original file line number Diff line number Diff line change
@@ -7,7 +7,8 @@
"exports": {
"./package.json": "./package.json",
".": "./dist/src/index.js",
"./bin/server.js": "./bin/server.js"
"./bin/server.js": "./bin/server.js",
"./svelte-check": "./dist/src/svelte-check.js"
},
"scripts": {
"test": "cross-env TS_NODE_TRANSPILE_ONLY=true mocha --require ts-node/register \"test/**/*.test.ts\"",
48 changes: 35 additions & 13 deletions packages/language-server/src/svelte-check.ts
Original file line number Diff line number Diff line change
@@ -1,24 +1,25 @@
import { groupBy } from 'lodash';
import { isAbsolute } from 'path';
import ts from 'typescript';
import { Diagnostic, Position, Range } from 'vscode-languageserver';
import { WorkspaceFolder } from 'vscode-languageserver-protocol';
import { TextDocumentContentChangeEvent, WorkspaceFolder } from 'vscode-languageserver-protocol';
import { Document, DocumentManager } from './lib/documents';
import { Logger } from './logger';
import { LSConfigManager } from './ls-config';
import {
CSSPlugin,
LSAndTSDocResolver,
PluginHost,
SveltePlugin,
TypeScriptPlugin
} from './plugins';
import { Plugin } from './plugins';
import { CSSPlugin } from './plugins/css/CSSPlugin';
import { FileSystemProvider } from './plugins/css/FileSystemProvider';
import { createLanguageServices } from './plugins/css/service';
import { PluginHost } from './plugins/PluginHost';
import { SveltePlugin } from './plugins/svelte/SveltePlugin';
import { JSOrTSDocumentSnapshot } from './plugins/typescript/DocumentSnapshot';
import { DiagnosticsProviderImpl } from './plugins/typescript/features/DiagnosticsProvider';
import { isInGeneratedCode } from './plugins/typescript/features/utils';
import { LSAndTSDocResolver } from './plugins/typescript/LSAndTSDocResolver';
import { convertRange, getDiagnosticTag, mapSeverity } from './plugins/typescript/utils';
import { pathToUrl, urlToPath } from './utils';
import { groupBy } from 'lodash';

export { offsetAt } from './lib/documents';

export type SvelteCheckDiagnosticSource = 'js' | 'css' | 'svelte';

@@ -95,11 +96,9 @@ export class SvelteCheck {
}
);
this.pluginHost.register(
new TypeScriptPlugin(
this.configManager,
new SvelteCheckTypeScriptPlugin(
this.lsAndTSDocResolver,
workspaceUris,
this.docManager
this.configManager,
)
);
}
@@ -354,3 +353,26 @@ export class SvelteCheck {
return this.lsAndTSDocResolver.getTSService(tsconfigPath);
}
}

export class SvelteCheckTypeScriptPlugin implements Plugin {
__name = 'ts';

constructor(lsAndTSDocResolver: LSAndTSDocResolver, lsConfigManager: LSConfigManager) {
this.lsAndTsDocResolver = lsAndTSDocResolver;
this.diagnosticsProvider = new DiagnosticsProviderImpl(lsAndTSDocResolver, lsConfigManager);
}

private readonly diagnosticsProvider: DiagnosticsProviderImpl;
private readonly lsAndTsDocResolver: LSAndTSDocResolver;

getDiagnostics(document: Document): Promise<Diagnostic[]> {
return this.diagnosticsProvider.getDiagnostics(document);
}

async updateTsOrJsFile(
fileName: string,
changes: TextDocumentContentChangeEvent[]
): Promise<void> {
await this.lsAndTsDocResolver.updateExistingTsOrJsFile(fileName, changes);
}
}
2 changes: 1 addition & 1 deletion packages/svelte-check/src/index.ts
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ import { watch } from 'chokidar';
import * as fs from 'fs';
import { fdir } from 'fdir';
import * as path from 'path';
import { SvelteCheck, SvelteCheckOptions } from 'svelte-language-server';
import { SvelteCheck, SvelteCheckOptions } from 'svelte-language-server/svelte-check';
import { Diagnostic, DiagnosticSeverity } from 'vscode-languageserver-protocol';
import { URI } from 'vscode-uri';
import { parseOptions, SvelteCheckCliOptions } from './options';
2 changes: 1 addition & 1 deletion packages/svelte-check/src/writers.ts
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ import pc from 'picocolors';
import { sep } from 'path';
import { Writable } from 'stream';
import { Diagnostic, DiagnosticSeverity } from 'vscode-languageserver-protocol';
import { offsetAt } from 'svelte-language-server';
import { offsetAt } from 'svelte-language-server/svelte-check';

export interface Writer {
start: (workspaceDir: string) => void;