Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Couldn't replicate [#1124](https://github.com/sveltejs/sapper/issues/1124) #1203

Closed
wants to merge 1 commit into from

Conversation

jervtub
Copy link

@jervtub jervtub commented May 16, 2020

Couldn't replicate issue. #1124

Add a new hydrate test folder with a test on whether the comments are printed correctly. link to test code

Add test to show issue didn't manage to replicate issue:
_"<script>'s in <svelte:head> are running twice (unless wrapped in
{@html})"_
@benmccann
Copy link
Member

@jervtub is this still a useful PR now that you've managed to replicate the problem? #1124 (comment)

@benmccann
Copy link
Member

Hi @jervtub - just checking in on this. Should we close this PR or is it still useful?

@benmccann
Copy link
Member

@jervtub I haven't heard from you. is there still value to this PR or should it be closed?

@benmccann
Copy link
Member

@jervtub I'm going to go ahead and close this since I haven't heard from you, but please let me know if you're still interested in this and we can reopen

@benmccann benmccann closed this Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants